feat(RouteList): implement infinite scrolling #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deployed preview: https://117.connect-d5y.pages.devWelcome to new-connect! Make sure to:
Mobile
Desktop
|
|
@adeebshihadeh I'm leaving this in draft since it was whipped up quickly as a POC. If this is of interest I can refactor the code, add test and set the PR to Ready. |
|
I like the look of this and it looks pretty simple too |
|
It only loads 6 routes on desktop, so it doesn't fill up the space, and you can't scroll to load more. Other than that, this is nice!
|
incognitojam
force-pushed
the
lazy-load
branch
from
264ea45 to
f38c58f
Compare
|
I reverted the style changes (grid layout) because we might be removing the map from the RouteCard and a list would be better for showing all of the routes |
incognitojam
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the RouteList component by introducing infinite scrolling and a responsive grid layout. These changes enhance user experience, performance, and maintainability while reducing manual interactions.